Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enterprisesearch input to metricbeat spec #2121

Merged
merged 1 commit into from
Jan 17, 2023
Merged

add enterprisesearch input to metricbeat spec #2121

merged 1 commit into from
Jan 17, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Jan 17, 2023 •
edited
Loading

What does this PR do?

Adds the enterprisesearch/metrics input to the metricbeat spec.

Why is it important?

This is necessary for the related package to work. If not agent will throw an input not supported error starting 8.6.0

{"log.level":"error","@timestamp":"2023-01-16T22:21:10.953Z","log.origin":{"file.name":"coordinator/coordinator.go","file.line":833},"message":"Spawned new unit enterprisesearch/metrics-default-enterprisesearch/metrics-enterprisesearch-3ac61e2c-dfa1-4d5b-af90-4ab353a576cb: input not supported","component":{"id":"enterprisesearch/metrics-default","state":"FAILED"},"unit":{"id":"enterprisesearch/metrics-default-enterprisesearch/metrics-enterprisesearch-3ac61e2c-dfa1-4d5b-af90-4ab353a576cb","type":"input","state":"FAILED"},"ecs.version":"1.6.0"}

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

@klacabane klacabane added the enhancement New feature or request label Jan 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

This pull request does not have a backport label. Could you fix it @klacabane? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-17T15:34:30.050+0000

  • Duration: 17 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 4825
Skipped 13
Total 4838

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍
Files 69.268% (142/205) 👍
Classes 69.231% (270/390) 👍
Methods 54.047% (828/1532) 👍
Lines 39.185% (8991/22945) 👎 -0.074
Conditionals 100.0% (0/0) 💚

@klacabane klacabane added the Team:Elastic-Agent Label for the Agent team label Jan 17, 2023
@klacabane klacabane marked this pull request as ready for review January 17, 2023 15:33
@klacabane klacabane requested a review from a team as a code owner January 17, 2023 15:33
@klacabane klacabane requested review from blakerouse and michel-laterman and removed request for a team January 17, 2023 15:33
@klacabane
Copy link
Contributor Author

/test

@klacabane klacabane mentioned this pull request Jan 17, 2023
Closed
@cmacknz cmacknz merged commit 2ddde8a into elastic:main Jan 17, 2023
@klacabane klacabane mentioned this pull request Jan 23, 2023
Merged
klacabane added a commit to elastic/kibana that referenced this pull request Jan 30, 2023
@klacabane @kibanamachine
[Stack Monitoring] support entsearch package (#148668)
870f79d 
### Summary

Update stack monitoring to read from data streams created by the
[enterprisesearch
package](elastic/integrations#4926)

### Testing
- build [enterprisesearch
package](elastic/integrations#4926)
- start stack: `elastic-package stack up -v -d --version
8.7.0-SNAPSHOT`; make sure your image contains [this
change](elastic/elastic-agent#2121)
- start enterprisesearch service: `elastic-package service up -v`
- install elasticsearch integration with variables
- `hosts: http://host.docker.internal:9201; username: elastic; password:
changeme`
- install enterprisesearch integration with variables
- `hosts: http://host.docker.internal:3002; username: elastic; password:
changeme`
- connect [local
kibana](https://github.com/elastic/kibana/blob/2d893bf40b47864058065f8fd2998d63c87f65f9/x-pack/plugins/monitoring/dev_docs/how_to/work_with_packages.md#connecting-a-local-kibana)
- navigate to Stack Monitoring on the local kibana, enterprise search
section shows up with populated graphs

---------

Co-authored-by: Kibana Machine <[email protected]>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@klacabane @kibanamachine @kqualters-elastic
[Stack Monitoring] support entsearch package (elastic#148668)
04c37c9 
### Summary

Update stack monitoring to read from data streams created by the
[enterprisesearch
package](elastic/integrations#4926)

### Testing
- build [enterprisesearch
package](elastic/integrations#4926)
- start stack: `elastic-package stack up -v -d --version
8.7.0-SNAPSHOT`; make sure your image contains [this
change](elastic/elastic-agent#2121)
- start enterprisesearch service: `elastic-package service up -v`
- install elasticsearch integration with variables
- `hosts: http://host.docker.internal:9201; username: elastic; password:
changeme`
- install enterprisesearch integration with variables
- `hosts: http://host.docker.internal:3002; username: elastic; password:
changeme`
- connect [local
kibana](https://github.com/elastic/kibana/blob/2d893bf40b47864058065f8fd2998d63c87f65f9/x-pack/plugins/monitoring/dev_docs/how_to/work_with_packages.md#connecting-a-local-kibana)
- navigate to Stack Monitoring on the local kibana, enterprise search
section shows up with populated graphs

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@klacabane klacabane

Labels
backport-skip enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klacabane @elasticmachine @cmacknz